Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making any changes to a cask, existing or new, verify:
brew audit --cask --online ghdl
is error-free.brew style --fix ghdl
reports no offenses.Hi, After #168502 was merged trying to use GHDL results in the following error:
The new version expects the following binary and directories to be linked, whereas the previous version does not. Reverting to 79b16a2 confirms that GHDL 3.0.0 works fine without the binary and directories being linked.
I added a link and unlink step in the postflight, which seems to have resolved the issue.
I am not entirely sure why ghdl is a cask, as it seems it could easily be a formula, If that is the preferred fix, I can create a formula as well.